Thread (5 messages) 5 messages, 3 authors, 2007-05-30

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

From: Jeff Garzik <hidden>
Date: 2007-05-30 00:42:40
Also in: lkml

Jeremy Fitzhardinge wrote:
Jeff Garzik wrote:
quoted
quoted
+        t3_intr_handler(adapter, qs->rspq.polling) (0,
+                    (adapter->flags & USING_MSIX) ?
+                    (void *)qs : (void *)adapter);
Remove needless casts to void*
The two branches of ?: need to have the same type; without the casts
they'd be "struct sge_qset" and "struct adapter".  Seems a bit cruddy to
have two types passed to one function depending on the MSI state, but
maybe that's OK.
Look at the function argument...

	Jeff


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help