Re: [PATCH 3/3] Intel IXP4xx network drivers

Michael-Luke Jones [off-list ref] writes:

Code placement:
Queue Manager & NPE code => arch/arm/mach-ixp4xx
WAN driver code => drivers/net/wan
Eth code => drivers/net/arm

Why would you want such placement?
Potential problems: header files would have to be moved to
include/asm-arm = headers pollution.
All 4 drivers are, in fact, network (related) drivers.

drivers/net/arm would probably make (some) sense if it was
a single (or not so single) Ethernet driver.

Kconfig:
I'm not convinced about 'config IXP4XX_NETDEVICES'. I'd lose it
together with the drivers/net/ixp4xx directory

It wouldn't make sense without the directory, no doubt.

Ethernet & HSS code should probably select NPE and QMGR (rather than
depend)

Actually, that's exactly what this patch do.

but these options should still be exposed in arch/arm/mach-
ixp4xx/Kconfig

Why exactly? They are network devices, who would expect them there?
How about the dependency mess (NET_ETHERNET etc.) that would be
created?
-- 
Krzysztof Halasa