Thread (7 messages) flat view 7 messages, 2 authors, 2007-05-11

Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page()

From: David Howells <dhowells@redhat.com>
Date: 2007-05-11 10:03:37
Also in: linux-fsdevel, lkml

Andrew Morton [off-list ref] wrote:
Yes, it's a shame that there doesn't seem to be a fine-grained way of
turning on -W's useful bits.
You can turn off -W's undesirable bits.  For net/rxrpc/ and fs/afs/ at least,
adding:

	CFLAGS += -W -Wno-unused-parameter

to the Makefile generates no warnings.  Perhaps this should be added to the
master Makefile.

Adding -Wsign-compare finds some stuff that I will fix.  It also finds some
stuff in the main and the networking headers.  This is a really useful option
and found some tricky bugs in CacheFiles.  I would endorse adding this
generally too.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help