Thread (2 messages) 2 messages, 2 authors, 2007-05-31

Re: [TG3]: Fix link problem on Dell's onboard 5906.

From: David Miller <davem@davemloft.net>
Date: 2007-05-31 21:50:11

From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 31 May 2007 15:03:39 -0700
[TG3]: Fix link problem on Dell's onboard 5906.

The bug is caused by code that always set
(TG3_FLAG_USE_MI_INTERRUPT | TG3_FLAG_USE_LINKCHG_REG) on all Dell's
onboard devices.  With these 2 flags set, the link status is polled
by tg3_timer() and will only work when the PHY is set up to interrupt
the MAC on link changes.  This breaks 5906 because the 5906 PHY does
not support TG3_FLAG_USE_MI_INTERRUPT the same as other PHYs.

For correctness, only Dell's onboard 5701 needs these 2 flags to be
set.  This change will fix the 5906 problem and will change other
Dell devices except 5700 and 5701 to use the more efficient
interrupt-driven link changes.

Update version to 3.77.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied, thanks for fixing this bug Michael.

That Dell onboard chip logic is definitely my fault :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help