Thread (11 messages) 11 messages, 3 authors, 2007-05-17

Re: [PATCH] sky2: re-enable 88E8056 for most motherboards

From: Stephen Hemminger <hidden>
Date: 2007-05-10 16:02:28

On Tue, 01 May 2007 09:58:28 -0400
Daniel Drake [off-list ref] wrote:
Hi Stephen,

Stephen Hemminger wrote:
quoted
This fixes the regression in 2.6.21 for users with 88e8056 on motherboard.
Allow all but the Gigabyte motherboard has some unresolved bus problems.
quoted
+	/* Some Gigabyte motherboards have 88e8056 but cause problems
+	 * There is some unresolved hardware related problem that causes
+	 * descriptor errors and receive data corruption.
+	 */
+	if (pdev->vendor == PCI_VENDOR_ID_MARVELL &&
+	    pdev->device == 0x4364 && pdev->subsystem_vendor == 0x1458) {
+		dev_err(&pdev->dev,
+			"88E8056 on Gigabyte motherboards not supported\n");
Gentoo have reports of sky2 working fine on Gigabyte boards which have 
88E8056 devices:
https://bugs.gentoo.org/show_bug.cgi?id=176219

Can the patch be refined further?
I can use DMI to narrow down to one motherboard. 
Or just let everything through and let user's discover what's unstable, it fails
relatively quickly.

Could you please get full PCI info lspci -vvxxx for working/non-working 88e8056 (Yukon EC-U)
systems? It might be some PCI Express setup by the BIOS, but so far haven't
found any difference that mattered.

Have tried newer BIOS and qualified memory as obvious first steps.


-- 
Stephen Hemminger [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help