Thread (40 messages) 40 messages, 9 authors, 2007-05-11

RE: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

From: Waskiewicz Jr, Peter P <hidden>
Date: 2007-04-25 17:45:55
Also in: lkml

-----Original Message-----
From: J Hadi Salim [mailto:j.hadi123@gmail.com] On Behalf Of jamal
Sent: Wednesday, April 25, 2007 4:37 AM
To: Stephen Hemminger
Cc: Waskiewicz Jr, Peter P; netdev@vger.kernel.org; 
linux-kernel@vger.kernel.org; jgarzik@pobox.com; cramerj; 
Kok, Auke-jan H; Leech, Christopher; davem@davemloft.net
Subject: Re: [PATCH] IPROUTE: Modify tc for new PRIO 
multiqueue behavior

On Tue, 2007-24-04 at 21:05 -0700, Stephen Hemminger wrote:
quoted
Peter P Waskiewicz Jr wrote:
quoted
Only if this binary compatiable with older kernels.
It is not. But i think that is a lesser problem, the bigger 
question is:
Why would you need to change a qdisc just so you can support 
egress multiqueues?
The previous version of my multiqueue patches I sent for consideration
had feedback from Patrick McHardy asking that the user be able to
configure the PRIO qdisc to run with multiqueue support or not.  That is
why TC needed a modification, since I agreed with Patrick that this
would be a useful option.

All the versions of multiqueue network device support I've sent for
consideration had PRIO modified to support multiqueue devices, since it
lends itself well for the model of multiple, independent flows.
BTW, is there any reason this is being cced to lkml?
Since this change affects how tc interacts with the qdisc layer, I cced
lkml.
cheers,
jamal

PS:- I havent read the kernel patches (i am congested and 
about 1000 messages behind on netdev) and my opinions may be 
influenced by an approach i have in trying to help someone 
fixup a wireless driver with multiqueue support.
As long as someone is looking at them, I'll be happy.  :-)

Thanks,

-PJ Waskiewicz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help