Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX
From: Atsushi Nemoto <hidden>
Date: 2007-04-30 15:14:26
Also in:
linux-mips
From: Atsushi Nemoto <hidden>
Date: 2007-04-30 15:14:26
Also in:
linux-mips
On Sun, 29 Apr 2007 02:10:37 +0900 (JST), Atsushi Nemoto [off-list ref] wrote:
quoted
platform_device_register_simple() copies *res by value, so I believe we can make res[] static __initdata. This way we don't need to evaluate the array on the stack at runtime, and the data gets discarded after initcalls have run. Can you please review and test the below? I had a go but wasn't able to fumble my way to a suitable config (I hope):It looks OK. I will merge your fix to updated patch. Thank you.
Unfortunately, the RBTX4938 part can not be converted to static __initdata since RBTX4938_RTL_8019_BASE is not a constant. And I think the change for toshiba_rbtx4927_rtc_init() should be an another patch. So I will add the "static __initdata" only to rbtx4927_ne_init(). --- Atsushi Nemoto