On Wed, Apr 11, 2007 at 10:15:51PM +1000, Rusty Russell wrote:

Actually, I did this precisely because I really didn't want to start
exposing bogus stats in /proc/net/dev.  An audit might clarify if this
is an actual issue.

Fair enough.  Still returning zeros when get_stats isn't available
would seem safe enough.  I wasn't able to find any drivers which
didn't have get_stats.

quoted

This also fixes a potential crash in those get_stats callers that
don't check for a NULL return value (e.g., /proc/net/dev).

Hmm, I thought it did that in my original patch?

Sorry, I was looking at the wrong tree.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt