Thread (13 messages) 13 messages, 5 authors, 2007-03-21

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2007-03-20 23:44:24
Also in: lkml, virtualization, xen-devel

Possibly related (same subject, not in this thread)


On Tue, 20 Mar 2007, Andi Kleen wrote:
On Tue, Mar 20, 2007 at 11:49:39AM -0700, Linus Torvalds wrote:
quoted
the thing is, I'd rather see a long backtrace that is hard to decipher but 
that *never* *ever* causes any additional problems, over a pretty one.
Well it causes additional problems. We had some cases where it was really
hard to distingush garbage and the true call chain. I can probably dig
out some examples if you want.
Well, by "additional problems" _I_ mean things like "a warning turned into 
a fatal oops and didn't get logged at all".

That's a lot more serious than "there were a few extra entries in the 
traceback that caused us some confusion".

And yes, we had exactly that case happen several times.
With lots of call backs (e.g. common with sysfs) it is also frequently
not obvious how the call chains are supposed to go.
With callbacks, it's actually often nice to see the callback data that is 
on the stack (and it's very obvious from the "<function+0>" ksymtab 
explanation: you can't have a <function+0> that is anything but a callback 
pointer (since it isn't a return address).

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help