Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly
From: <hidden>
Date: 2007-03-08 22:56:10
Also in:
lkml
On Thu, 08 Mar 2007 22:48:29 GMT, David Howells said:
quoted hunk
diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 779aa78..ce092fe 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h@@ -40,7 +40,10 @@ #define CRYPTO_ALG_LARVAL 0x00000010 #define CRYPTO_ALG_DEAD 0x00000020 #define CRYPTO_ALG_DYING 0x00000040 -#define CRYPTO_ALG_ASYNC 0x00000080 + +#define CRYPTO_ALG_CAP_MASK 0x00000180 /* capabilities mask */ +#define CRYPTO_ALG_ASYNC 0x00000080 /* capable of async operation */ +#define CRYPTO_ALG_DMA 0x00000100 /* capable of using of DMA */
Would it make sense to define ALG_CAP_MASK as 0xF80 or similar, to reserve a few bits? The alternative has somebody else grabbing 0x200 for some other purpose, and then when you want to add another capability bit, you end up with a CAP_MASK of 0x580 - this way leads to madness and bugs....
Attachments
- (unnamed) [application/pgp-signature] 226 bytes