Thread (3 messages) 3 messages, 2 authors, 2007-03-30

Re: net nasties in davem's tree

From: David Miller <davem@davemloft.net>
Date: 2007-03-30 02:06:05

From: David Miller <davem@davemloft.net>
Date: Thu, 29 Mar 2007 19:03:17 -0700 (PDT)
From: Andrew Morton <akpm@linux-foundation.org>
Date: Thu, 29 Mar 2007 18:37:30 -0700
quoted
drivers/net/3c523.c: In function 'elmc_send_packet':
drivers/net/3c523.c:1148: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
drivers/net/ni52.c: In function 'ni52_send_packet':
drivers/net/ni52.c:1185: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
We should probably mark the "to" argument to skb_copy_from_linear_data()
as const, I'll take care of that.

Thanks for the report.
My bad, what's going on in the first case is the driver
has "volatile disease".  I'll add back the (char *) cast
that was in the original memcpy().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help