Re: [RESEND] [NET] fib_rules: Flush route cache after rule modifications
From: David Miller <davem@davemloft.net>
Date: 2007-03-28 18:24:23
From: David Miller <davem@davemloft.net>
Date: 2007-03-28 18:24:23
From: Thomas Graf <tgraf@suug.ch> Date: Wed, 28 Mar 2007 17:49:03 +0200
* Jarek Poplawski [off-list ref] 2007-03-28 13:19quoted
I hope I'm wrong, but isn't this at the cost of admins working with long rules' sets, which (probably) take extra time now?That's right, it makes the insert and delete operation more expensive. A compromise would be to delay the flushing and wait for some time (default 2 seconds) whether more rules or routes are being added before flushing.
Another idea Thomas and I tossed around was to have some kind of way for the rule insertion to indicate that the flush should be deferred and I kind of prefer that explicitness. By default it's better the flush immediately, because the old behavior is totally unexpected. "I insert a rule and it dosn't show up?", nobody expects that.