Re: [PATCH] NET : secure sequence number functions can use nsec resolution instead of usec
From: Andi Kleen <hidden>
Date: 2007-03-28 16:41:35
From: Andi Kleen <hidden>
Date: 2007-03-28 16:41:35
On Wed, Mar 28, 2007 at 05:43:22PM +0200, Eric Dumazet wrote:
Hello David We could use the nanosec resolution for various functions defined in drivers/char/random.c (secure_tcpv6_sequence_number(), secure_tcp_sequence_number(), secure_dccp_sequence_number()) I am not sure if it's a netdev related patch or core kernel, so I have CC Andrew. Thank you [PATCH] NET : random functions can use nsec resolution instead of usec In order to get more randomness for secure_tcpv6_sequence_number(), secure_tcp_sequence_number(), secure_dccp_sequence_number() functions, we can use the high resolution time services, providing nanosec resolution.
It's also a little faster because it avoids one division. You didn't mention the initial seed change. There you could have removed the useless utsname initialization too.
I've also done two kmalloc()/kzalloc() conversions.
Normally that should be separate patches -Andi