Thread (5 messages) 5 messages, 3 authors, 2007-03-28

Re: [1/1] netlink: no need to crash if table does not exist.

From: Evgeniy Polyakov <hidden>
Date: 2007-03-28 08:43:37

On Tue, Mar 27, 2007 at 04:41:54PM -0700, David Miller (davem@davemloft.net) wrote:
quoted
There is no problem as-is, but I implement unified cache for different
sockets (currently tcp/udp/raw and netlink are supported), which does
not use that table, so I currently wrap all access code into special
ifdefs, this one can be wrapped too, but since it is not needed, it
saves couple of lines of code.
It is needed.  It is there to make sure that a kernel netlink
socket is not created before the af_netlink init code runs.

We've had sequencing bugs like that in the initcall call chain
in the past, that's why the check is there.
Argh, I see.
I fail to find exact commit (at least it was not in 2.4 and was created
before 2.6.12), but it is ineed neeed.

Thanks for explaination.

-- 
	Evgeniy Polyakov
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help