Re: [PATCH] NET : align inet_protos[] on SMP
From: David Miller <davem@davemloft.net>
Date: 2007-03-27 21:20:18
From: David Miller <davem@davemloft.net>
Date: 2007-03-27 21:20:18
From: Eric Dumazet <redacted> Date: Tue, 27 Mar 2007 15:47:04 +0200
As IPPROTO_TCP is 6, it makes sense to make sure inet_protos[] array is properly cache line aligned to avoid false sharing on SMP. c0680540 b peer_total c0680544 b inet_peer_unused_head c0680560 B inet_protos On i386 this example, we can see that inet_protos[IPPROTO_TCP] shares a potentially hot (and modified) cache line. Signed-off-by: Eric Dumazet <redacted>
Applied, thanks again Eric. We could probably add some const markings to these things as well.