Re: [PATCH] spidernet : fix memory leak in spider_net_stop
From: Linas Vepstas <hidden>
Date: 2007-02-01 17:36:18
Also in:
linuxppc-dev
A variant of this patch is queued up for 2.6.21, as a part of the patch http://www.mail-archive.com/netdev@vger.kernel.org/msg28213.html I beleive its in the -mm tree, I have not checked. --linas On Thu, Feb 01, 2007 at 12:07:47PM +0100, Jens Osterkamp wrote:
quoted hunk ↗ jump to hunk
We forget to call spider_net_free_rx_chain_contents which does the actual dev_kfree_skb. New skbs are allocated from skbuff_head_cache on each "ifconfig up" letting the cache grow infinitely. This patch fixes it. Signed-off-by: Jens Osterkamp <redacted> Index: linux-2.6.20-rc6/drivers/net/spider_net.c ===================================================================--- linux-2.6.20-rc6.orig/drivers/net/spider_net.c +++ linux-2.6.20-rc6/drivers/net/spider_net.c@@ -1925,6 +1925,8 @@ spider_net_stop(struct net_device *netde /* release chains */ spider_net_release_tx_chain(card, 1); + spider_net_free_rx_chain_contents(card); + spider_net_free_chain(card, &card->tx_chain); spider_net_free_chain(card, &card->rx_chain);