Thread (17 messages) 17 messages, 5 authors, 2007-03-12

Re: [PATCH 1/2] NET: Multiple queue network device support

From: David Miller <davem@davemloft.net>
Date: 2007-02-27 01:03:20
Also in: lkml

From: "Kok, Auke" <redacted>
Date: Thu, 08 Feb 2007 16:09:50 -0800
From: Peter Waskiewicz Jr <redacted>

Added an API and associated supporting routines for multiqueue network
devices.  This allows network devices supporting multiple TX queues to
configure each queue within the netdevice and manage each queue
independantly.  Changes to the PRIO Qdisc also allow a user to map
multiple flows to individual TX queues, taking advantage of each queue
on the device.

Signed-off-by: Peter Waskiewicz Jr <redacted>
Signed-off-by: Auke Kok <redacted>
Thanks for posting this.

I was wonding if it would be better to have the ->enqueue() perform
the mapping operation, store the queue index selected inside of the
skb, and just use the normal ->hard_start_xmit() to send the packet
out?

The only thing to take care of is the per-queue locking, but that
should be easily doable.

We might be able to do this even without making sk_buff any larger.
For example, I suppose skb->priority might be deducable down to
a u16.  After a quick audit I really cannot see any legitimate use
of anything larger than 16-bit values, but a more thorough audit
would be necessary to validate this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help