Thread (2 messages) flat view 2 messages, 2 authors, 2007-02-04

Re: [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c

From: David Miller <davem@davemloft.net>
Date: 2007-02-04 20:23:50
Also in: lkml

From: Thomas Hisch <redacted>
Date: Sun, 4 Feb 2007 15:29:21 +0100
remove unneeded call to skb_queue_len (skb_dequeue already checks queuelen) and
replace a sizeof() by a Netlink Macro

Signed-off-by: Thomas Hisch <redacted>
You don't understand the code you are editing :-)

We want to process the number of packets present when we
start the function, other threads can add more packets to
the queue meanwhile and we don't want to keep dequeueing
in that case or else we can theoretically run forever with
a fast enough producer.

Also, please post all networking patches to netdev@vger.kernel.org,
the majority of the networking developers do not read linux-kernel.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help