Re: [PATCH] netxen: do_rom_fast_write error handling
From: Amit Kale <hidden>
Date: 2007-02-27 06:40:42
Ah.. missed that. Thanks. -Amit On Tuesday 27 February 2007 04:21, Stephen Hemminger wrote:
quoted hunk ↗ jump to hunk
Compiler warning spots real error! The function do_rom_fast_read called in do_rom_fast_write can fail and leave data1 unset. This causes a compile warning. The correct thing is to propagate the error out. Signed-off-by: Stephen Hemminger <redacted> --- drivers/net/netxen/netxen_nic_init.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)--- pktgen.orig/drivers/net/netxen/netxen_nic_init.c 2007-02-2614:45:46.000000000 -0800 +++ pktgen/drivers/net/netxen/netxen_nic_init.c 2007-02-26 14:46:37.000000000 -0800 @@ -499,7 +499,10 @@ while(1) { int data1; - do_rom_fast_read(adapter, addridx, &data1); + ret = do_rom_fast_read(adapter, addridx, &data1); + if (ret < 0) + return ret; + if (data1 == data) break;