Re: [PATCH 4/5] r8169: more alignment for the 0x8168
From: Mike Isely <hidden>
Date: 2007-02-13 23:37:53
On Tue, 13 Feb 2007, Francois Romieu wrote:
Philip Craig [off-list ref] : [...]quoted
This patch caused a drop in throughput from 178 Mbits/sec to 135 Mbits/sec on an Intel XScale IXP465.Which distribution of packet sizes ?quoted
It seems like there is some confusion about what the align parameter here means. It was originally an offset from an aligned address so that the IP header aligned, and this patch changes it to the alignment of the ethernet header. But align is still set to NET_IP_ALIGN for some chips.Yes, I should have distinguished both in the first place. Can you describe which chipset from realtek the board is using (lspci -vxx) ?
Francois:
Obviously I have an interest in any change here not breaking the NIC on
my system. So please let me know if/when you'd like me to test drive a
candidate fix that keeps everyone happy...
-Mike
--
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |