Re: [PATCH 1/3] d80211: Add control structure for beacontemplates
From: Jiri Benc <hidden>
Date: 2007-02-08 18:10:46
Also in:
linux-wireless
On Tue, 6 Feb 2007 00:46:45 +0100, Ivo van Doorn wrote:
quoted hunk
--- dscape/net/d80211/ieee80211.c 2007-02-06 00:19:38.000000000 +0100 +++ dscape.control/net/d80211/ieee80211.c 2007-02-06 00:25:26.000000000 +0100@@ -1857,7 +1857,8 @@ ieee80211_get_buffered_bc(struct ieee802 EXPORT_SYMBOL(ieee80211_get_buffered_bc); static int __ieee80211_if_config(struct net_device *dev, - struct sk_buff *beacon) + struct sk_buff *beacon, + struct ieee80211_tx_control *control) { struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev); struct ieee80211_local *local = dev->ieee80211_ptr;@@ -1881,6 +1882,7 @@ static int __ieee80211_if_config(struct conf.generic_elem = sdata->u.ap.generic_elem; conf.generic_elem_len = sdata->u.ap.generic_elem_len; conf.beacon = beacon; + memcpy(&conf.beacon_control, control, sizeof(*control));
We can save this memcpy if ieee80211_if_conf.beacon_control is just a pointer. With the exception of this, the patch looks good now. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html