Re: [PATCH 2/5] fixing errors handling during pci_driver resume stage [ata]
From: Grant Grundler <hidden>
Date: 2007-01-12 23:50:59
Also in:
linux-scsi, lkml
On Tue, Jan 09, 2007 at 12:01:28PM +0300, Dmitriy Monakhov wrote:
ata pci drivers have to return correct error code during resume stage in case of errors.
...
quoted hunk ↗ jump to hunk
@@ -6246,8 +6253,10 @@ int ata_pci_device_suspend(struct pci_de int ata_pci_device_resume(struct pci_dev *pdev) { struct ata_host *host = dev_get_drvdata(&pdev->dev); + int err; - ata_pci_device_do_resume(pdev); + if ((err = ata_pci_device_do_resume(pdev))) + return err;
nit: in every other case I looked at you did: err = foo() if (err) ... Can you make that consistent here too? thanks, grant