Thread (13 messages) read the whole thread 13 messages, 1 author, 2007-01-03
DORMANTno replies

Revision v1 of 6 in this series.

Revisions (6)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 [diff vs current]
  5. v1 current
  6. v1 [diff vs current]

[PATCH 12/12] d80211: Reinit keys on mode change

From: Jiri Benc <hidden>
Date: 2007-01-03 18:05:25
Subsystem: networking [general], the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

From: Jan Kiszka <redacted>

Switching the interface mode with some encryption keys set and then later
touching any key, triggers an oops because ieee80211_if_reinit fails to
NULL'ify the related pointers after free'ing the key on mode change. Long
explanation, simple fix below.

Signed-off-by: Jan Kiszka <redacted>
Signed-off-by: Jiri Benc <redacted>

---

 net/d80211/ieee80211_iface.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

ff6a6797032d232d07be32594fdd7369cd927382
diff --git a/net/d80211/ieee80211_iface.c b/net/d80211/ieee80211_iface.c
index cb1da56..1a0b8cd 100644
--- a/net/d80211/ieee80211_iface.c
+++ b/net/d80211/ieee80211_iface.c
@@ -231,6 +231,7 @@ #if 0
 					    local->keys[i], 0);
 #endif
 		ieee80211_key_free(sdata->keys[i]);
+		sdata->keys[i] = NULL;
 	}
 
 	/* Shouldn't be necessary but won't hurt */
-- 
1.3.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help