Re: [RFC][PATCH -mm 3/5] add interface for netconsole using sysfs
From: Keiichi KII <hidden>
Date: 2006-12-26 04:53:59
Also in:
lkml
From: Keiichi KII <hidden>
Date: 2006-12-26 04:53:59
Also in:
lkml
Thank you for your replies and reviews. I will follow your advices.
quoted
static LIST_HEAD(target_list); static DEFINE_SPINLOCK(target_list_lock); +static ssize_t show_local_ip(struct netconsole_target *nt, char *buf) +{ + return sprintf(buf, "%d.%d.%d.%d\n", HIPQUAD(nt->np.local_ip));I don't understand the use of HIPQUAD() here instead of NIPQUAD(). Explain? Also, NIPQUAD_FMT (in kernel.h) uses "%u.%u.%u.%u". This should probably be the same. Or just use: NIPQUAD_FMT "\n"
IP address is stored in the form of host byte order in netpoll structure. So, You can't use NIPQUAD to follow the current implementation of netpoll. -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: k-keiichi@bx.jp.nec.com