Thread (6 messages) 6 messages, 2 authors, 2006-12-27

Re: d80211 constants inside d80211_common.h

From: Michael Wu <hidden>
Date: 2006-12-27 19:12:57

On Wednesday 27 December 2006 12:26, Nick Kossifidis wrote:
We need those definitions for setting up the rate tables in dadwifi,
phytypes are needed inside drivers, take a look here ->
http://madwifi.org/browser/branches/dadwifi-openhal/openhal/ar5xxx.h?rev=18
67
MODE_IEEE80211A/B/G and IEEE80211_RATE_* not enough? The definitions in 
d80211_common.h are used for communications with userspace, not drivers. If 
you are using the ieee80211_phytype_* in things that are passed to d80211, it 
is wrong. If you are not, you can switch to MODE_IEEE80211A/B/G and 
IEEE80211_RATE_*, though I think MODE_IEEE80211A/B/G should be all you need.
Even if it does get out, constants should be in capitals.
Sure. Submit a patch. :)

-Michael Wu

Attachments

  • (unnamed) [application/pgp-signature] 189 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help