On Wed, Dec 27, 2006 at 07:58:54AM +0000, Christoph Hellwig wrote:

On Mon, Dec 18, 2006 at 05:53:59AM -0800, Amit S. Kale wrote:

quoted

Signed-off-by: Amit S. Kale <redacted> 
 
 netxen_nic.h      |    2 +-
 netxen_nic_init.c |   12 ++++++------
 netxen_nic_main.c |    4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

Please use __le* types for all hardware data structures and use sparse
to verify all your endianess handling is correct.

I have preliminary endianness annotations for that puppy; FWIW, a part of
it consists of _removing_ __le.  Folks, readl() returns host-endian and
writel() takes host-endian as argument.  They do conversions themselves.
One needs fixed-endian types in data structures shared with device - i.e.
anything in ioremapped area or dma'd to/from device.