Re: Generic PHY lib vs. locking
From: David Hollis <hidden>
Date: 2006-12-22 16:25:36
From: David Hollis <hidden>
Date: 2006-12-22 16:25:36
On Fri, 2006-12-22 at 15:07 +1100, Benjamin Herrenschmidt wrote:
Hi Andy ! I've been looking at porting various drivers (EMAC, sungem, spider_net, ...) to the generic PHY stuff. However, I have one significant problem here.
One solution would be to change it to use a mutex instead of a lock as well, though that would change the requirements of where phy_start/stop can be called, and use a delayed work queue instead of a timer.
Wouldn't this change also allow it to be used with USB Ethernet devices? I was looking at porting the asix.c drive to use the PHY layer but the locking killed that effort since USB devices can't do spinlocks without hosing things up. -- David Hollis [off-list ref]