Thread (15 messages) 15 messages, 1 author, 2006-12-13
STALE7130d
Revisions (7)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 current
  5. v1 [diff vs current]
  6. v1 [diff vs current]
  7. v1 [diff vs current]

[PATCH 10/14] d80211: Fix errorcode in ieee80211_update_hw

From: Jiri Benc <hidden>
Date: 2006-12-13 17:08:53
Subsystem: networking [general], the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

From: Michael Buesch <redacted>

ieee80211_update_hw should return a proper error code
instead of hardcoded -1.

Signed-off-by: Michael Buesch <redacted>
Signed-off-by: Jiri Benc <redacted>

---

 net/d80211/ieee80211.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

cca5b9bc1f21e1d9a616e0f8e2fea04140a51a07
diff --git a/net/d80211/ieee80211.c b/net/d80211/ieee80211.c
index 8d543f2..9e7e1b3 100644
--- a/net/d80211/ieee80211.c
+++ b/net/d80211/ieee80211.c
@@ -4635,7 +4635,7 @@ int ieee80211_update_hw(struct ieee80211
 
 	if (!hw->modes || !hw->modes->channels || !hw->modes->rates ||
 	    !hw->modes->num_channels || !hw->modes->num_rates)
-		return -1;
+		return -EINVAL;
 
 	ieee80211_precalc_modes(local);
 	local->hw.conf.phymode = hw->modes[0].mode;
-- 
1.3.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help