On Tue, Dec 05, 2006 at 12:07:17PM -0800, Stephen Hemminger wrote:

Fix sparse warnings and get rid of casts that hide misuse
of __user pointers.  There were two real bugs here:
  * ioctl was copying uninitialized stack om NETXEN_NIC_NAME
  * ioctl was dereferencing a user pointer
    in nettxen_nic_cmd_clear_stats.

IMHO the ioctl usage in this driver is going to be more maintenance
burden than useful. and should be removed.

Yes, please send a patch to kill the ioctls.  Given all the other mess
in the driver I really wonder who ACKed it going in.