Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

On Nov 19 2006 14:30, Jay Cliburn wrote:

+
+#define	LBYTESWAP( a )  ( ( ( (a) & 0x00ff00ff ) << 8 ) | ( ( (a) & 0xff00ff00 ) >> 8 ) )
+#define	LONGSWAP( a )	( ( LBYTESWAP( a ) << 16 ) | ( LBYTESWAP( a ) >> 16 ) )
+#define	SHORTSWAP( a )	( ( (a) << 8 ) | ( (a) >> 8 ) )

Please use swab16/swab32 for these.

+#define AT_DESC_UNUSED(R) \
+	((((R)->next_to_clean > (R)->next_to_use) ? 0 : (R)->count) + \
+	(R)->next_to_clean - (R)->next_to_use - 1)
+
+#define AT_DESC_USED(R) \
+	(((R)->next_to_clean > (R)->next_to_use) ?	\
+		((R)->count+(R)->next_to_use-(R)->next_to_clean+1) : \
+		((R)->next_to_use-(R)->next_to_clean+1))

These look like they are on the edge to be written as a static-inline function.
What do others think?

+#define AT_WRITE_REG(a, reg, value) ( \
+	writel((value), ((a)->hw_addr + reg)))
+
+#define AT_READ_REG(a, reg) ( \
+	readl((a)->hw_addr + reg ))
+
+#define AT_WRITE_REGB(a, reg, value) (\
+	writeb((value), ((a)->hw_addr + reg)))
+
+#define AT_READ_REGB(a, reg) (\
+	readb((a)->hw_addr + reg))
+
+#define AT_WRITE_REGW(a, reg, value) (\
+	writew((value), ((a)->hw_addr + reg)))
+
+#define AT_READ_REGW(a, reg) (\
+	readw((a)->hw_addr + reg))
+
+#define AT_WRITE_REG_ARRAY(a, reg, offset, value) ( \
+	writel((value), (((a)->hw_addr + reg) + ((offset) << 2))))
+
+#define AT_READ_REG_ARRAY(a, reg, offset) ( \
+	readl(((a)->hw_addr + reg) + ((offset) << 2)))

Possibly similarly.


	-`J'
--