General network driver suspend/resume (was e1000 carrier related)
From: Stephen Hemminger <hidden>
Date: 2006-11-08 19:54:55
Also in:
lkml
On Wed, 8 Nov 2006 13:04:07 +0100 Pavel Machek [off-list ref] wrote:
Hi!quoted
quoted
quoted
This behavior differs from every other network card, and is also present in the 7.3* version of the driver from sourceforge. I think the e1000 should try to raise the link during the probe, so that it works properly, without having to set ifconfig ethX up first.I think you should cc e1000 maintainers, and perhaps provide a patch....I've read it and not come up with an answer due to some other issues at hand. E1000 hardware works differently and this has been asked before, but the cards itself are in low power state when down. Changing this to bring up the link would make the card start to consume lots more power, which would automatically suck enormously for anyone using a laptop.Well, maybe E1000 should behave as the other cards behave, and different solution needs to be found for power saving? ifconfig eth0 suspend? Pavel
The standard which all network drivers should use is: module insertion: start in initial powerdown state open: power up, bring up link stop: bring down link return to powerdown state unless WOL is set. if doing WOL go to lowest power sensing state suspend: same as stop resume: same as open module removal: stop already called so device should be in power down state. Since suspend is basically same as stop, and resume is open I am going to investigate doing suspend/resume in the network device layer (unless subclassed by driver), so we can rip out the suspend/resume hook from many network drivers. There will still be boards like sky2 that need own suspend/resume to deal with dual port etc. -- Stephen Hemminger [off-list ref]