Re: [PATCH] r8169: Fix iteration variable sign
From: Michael Buesch <hidden>
Date: 2006-11-30 14:14:24
From: Michael Buesch <hidden>
Date: 2006-11-30 14:14:24
On Thursday 30 November 2006 12:20, Jeff Garzik wrote:
Francois Romieu wrote:quoted
This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for < 0 later, which can never happen for "unsigned". This results in broken error handling. Signed-off-by: Michael Buesch <redacted> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>ACK but doesn't seem to apply to 2.6.19? should this go into #upstream rather than #upstream-fixes?
Hm, I did this against latest linus' tree. -- Greetings Michael.