Re: [RFT] mv643xxx_eth_start_xmit oops

On Fri, 10 Nov 2006 22:03:43 +0100
Francois Romieu [off-list ref] wrote:

Dale Farnsworth [off-list ref] :
[...]

quoted

Can you provide more detail about the leak?

+       if (has_tiny_unaligned_frags(skb) && __skb_linearize(skb)) {
+               stats->tx_dropped++;
+               if (net_ratelimit())
+                       printk(KERN_DEBUG "%s: failed to linearize tiny "
+                              "unaligned fragment\n", dev->name);
+               return NETDEV_TX_OK;

Missing kfree_skb(skb) before returning NETDEV_TX_OK ?

skb_linearize is documented to free skb on failure.





-- 
Stephen Hemminger [off-list ref]