Re: [PATCH 2/14] [TIPC] Debug print buffer enhancements and fixes
From: David Miller <davem@davemloft.net>
Date: 2006-10-17 04:43:18
From: Per Liden <redacted> Date: Fri, 13 Oct 2006 13:37:43 +0200
From: Allan Stephens <redacted> This change modifies TIPC's print buffer code as follows: 1) Now supports small print buffers (min. size reduced from 512 bytes to 64) 2) Now uses TIPC_NULL print buffer structure to indicate null device instead of NULL pointer (this simplified error handling) 3) Fixed misuse of console buffer structure by tipc_dump() 4) Added and corrected comments in various places Signed-off-by: Allan Stephens <redacted> Signed-off-by: Per Liden <redacted>
Applied, please run trailing-whitespace checks on your patches,
f.e. using "git apply --check --whitespace=error-all diff".
Because often I have to fix up problems like the following in
your submissions:
davem@sunset:~/src/GIT/net-2.6$ pcheck diff
+ git apply --check --whitespace=error-all diff
Adds trailing whitespace.
diff:25: * TIPC_LOG : TIPC log buffer
Adds trailing whitespace.
diff:105: *
Adds trailing whitespace.
diff:148: *
Adds trailing whitespace.
diff:334: printk("\n---- Start of %s log dump ----\n\n",
Adds trailing whitespace.
diff:366: tipc_printbuf_init(TIPC_LOG, kmalloc(log_size, GFP_ATOMIC),
Adds trailing whitespace.
diff:393: * @next: used to link print buffers when printing to more than one at a time
Adds trailing whitespace.
diff:395:
fatal: 7 lines add trailing whitespaces.
Thanks.