Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.
From: Arnd Bergmann <arnd@arndb.de>
Date: 2006-09-30 10:33:47
Also in:
linuxppc-dev, lkml
Am Saturday 30 September 2006 01:21 schrieb Linas Vepstas:
This patch adds version information as reported by ethtool -i to the Spidernet driver. From: James K Lewis <redacted> Signed-off-by: James K Lewis <redacted> Signed-off-by: Linas Vepstas <redacted> Cc: Arnd Bergmann <arnd@arndb.de>
Same comment as last time this was submitted:
quoted hunk ↗ jump to hunk
@@ -2303,6 +2304,8 @@ static struct pci_driver spider_net_driv*/ static int __init spider_net_init(void) { + printk("spidernet Version %s.\n",VERSION); + if (rx_descriptors < SPIDER_NET_RX_DESCRIPTORS_MIN) { rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_MIN; pr_info("adjusting rx descriptors to %i.\n",
This is missing a printk level and a space character. More importantly, you should not print the presence of the driver to the syslog, but the presence of a device driven by it. Arnd <><