Thread (16 messages) 16 messages, 6 authors, 2006-09-30

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

From: Jeff Garzik <hidden>
Date: 2006-09-29 23:00:18

David Miller wrote:
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 29 Sep 2006 14:39:23 -0700
quoted
On Fri, 2006-09-29 at 17:28 -0400, Jeff Garzik wrote:
quoted
Michael Chan wrote:
quoted
AMD believes this incompatibility is unique to the 5706, and
prefers to locally disable MSI rather than globally disabling it
using pci_msi_quirk.
Why is it unique to the 5706?  Is this just a guess on AMD and 
Broadcom's part?
I just took AMD's word for it.  It doesn't matter to me whether we
disable it locally or globally.  Since this is AMD's bridge, I just
follow their recommendation.  They probably haven't seen this issue on
any other devices except ours.
I really think this is a reasonable thing to do.

It's absolutely rediculious to disable MSI for every card just
because one decided to use a masked 64-bit transaction for
what's supposed to be a 32-bit one.

Jeff, I totally understand your knee-jerk reaction to per-device MSI
validation checks, but in this case I find that knee-jerk reaction
to be totally unreasonable. :-)
How it is unreasonable to clarify a completely vague description of the 
problem?

The patch and description provided no information about whether or not 
it would be better to blacklist 8132 globally, as we have already done 
with the 8131.

	Jeff


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help