Re: [RFC] let mortals use ethtool
From: David Miller <davem@davemloft.net>
Date: 2006-09-28 22:13:55
From: "Michael Chan" <mchan@broadcom.com> Date: Thu, 28 Sep 2006 13:17:04 -0700
I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID. Dumping 64K worth of registers and blinking the LEDs should be restricted. But I have no problem doing these checks in the driver if necessary.
Ok I removed PHYS_ID and GREGS from the allowed list. Any others?