Re: [PATCH 2/12] smc911x: Fix SMC_WRITE_EEPROM_CMD macro

Hi,

Send again with this time to netdev also. I didnt notice Steve not including 
netdev in the first place.

Hi Francois/Bora,

quoted

quoted

Macro abuse. It should be a function.

Yes but I got smc911x.h and smc91x.h as a basis. In the smc911x.c
there are macros which is longer than it, e.g. SMC_GET_MII. In the
same way, smc91x.h contains even more longer like SMC_PUSH_DATA.
But, of course, it doesnt mean they are correct.

At SMSC (with help from ARM) we tidied up and posted our smsc911x driver
to the netdev list.  This uses a more "2.6" style, supports more devices,
contains additional workarounds for hardware issues and works on !arm.

I don't think Jeff has included this in 2.6 yet, so let me know if you
would like a copy.

I tracked your mails from archives. Well, as said, which one will be stay at 
the kernel, Dustin's or SMSC's? Because I have additional patches againist to 
in-kernel driver and maybe some more in the future. Our board is MIPS based.

PS: I am happy if you send me your patches privately...

--
Bora SAHIN