Thread (4 messages) flat view 4 messages, 4 authors, 2006-08-29

Re: call panic if nl_table allocation fails

From: Patrick McHardy <hidden>
Date: 2006-08-23 14:17:11
Also in: lkml

James Morris wrote:
On Wed, 23 Aug 2006, Akinobu Mita wrote:

quoted
This patch makes crash happen if initialization of nl_table fails
in initcalls. It is better than getting use after free crash later.
quoted
	nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL);

Perhaps it'd be better to declare this as an array rather than allocating 
it at runtime.
That would still leave the MAX_LINKS allocations for the pid hashes
which need to be allocated because they are dynamically sized. We
could delay the pid hash allocations until the first bind happens
of course, but I doubt it would be worth it since they start with
just a single bucket.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help