Re: [Patch] Signedness issue in drivers/net/3c515.c
From: Alan Cox <hidden>
Date: 2006-08-21 21:52:56
Also in:
lkml
Ar Llu, 2006-08-21 am 14:05 -0700, ysgrifennodd Andrew Morton:
/* Wait for the stall to complete. */ for (i = 20; i >= 0; i--) if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0) break; Your fix will convert this indefinit wait into a bounded one. It might cause the driver to malfunction.
The change is correct. The docs guarantee it can't take that long.