Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

Hi Alexey,

first of all thanks a lot for the extensive review.


Alexey Dobriyan wrote:

quoted

+	u64 hret = H_HARDWARE;

Useless assignment here and everywhere.

Initializing returncodes to errorstate is a cheap way to prevent
accidentally returning (uninitalized) success returncodes which
can lead to catastrophic misbehaviour.

quoted

+static void netdev_get_drvinfo(struct net_device *dev,
+			       struct ethtool_drvinfo *info)
+{
+	strncpy(info->driver, DRV_NAME, sizeof(info->driver) - 1);
+	strncpy(info->version, DRV_VERSION, sizeof(info->version) - 1);

Use strlcpy() to not forget -1 accidently.

I agree.

Kind regards
Thomas