Re: [2.6.19 PATCH 5/7] ehea: main header files
From: Alexey Dobriyan <hidden>
Date: 2006-08-18 14:16:12
Also in:
linuxppc-dev, lkml
On Fri, Aug 18, 2006 at 01:34:57PM +0200, Jan-Bernd Themann wrote:
quoted hunk ↗ jump to hunk
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h +++ kernel/drivers/net/ehea/ehea.h
+#include <linux/version.h>
Not needed.
+#include <linux/module.h> +#include <linux/moduleparam.h>
Really?
+#include <linux/kernel.h> +#include <linux/vmalloc.h> +#include <linux/mm.h> +#include <linux/slab.h> +#include <linux/sched.h> +#include <linux/err.h> +#include <linux/list.h> +#include <linux/netdevice.h> +#include <linux/etherdevice.h> +#include <linux/kthread.h>
Nothing is used here. grep kthread
+#include <linux/ethtool.h> +#include <linux/if_vlan.h>
It this because of "struct vlan_group" just add "struct vlan_group;" at the beginning of the headers.
+#include <asm/ibmebus.h> +#include <asm/of_device.h> +#include <asm/abs_addr.h> +#include <asm/semaphore.h> +#include <asm/current.h> +#include <asm/io.h>
Please, use only headers you only really need. Full rebuilds are already pretty enough. I've included half of include/linux disaster must stop.