Re: [PATCH 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code

Hello.

In article <200608160846.48174@strip-the-willow> (at Wed, 16 Aug 2006 08:46:48 +0100), gerrit@erg.abdn.ac.uk says:

UDPv4 and UDPv6 use an almost identical version of the get_port function,
which is unnecessary since the (long) code differs in only one if-statement.

:

:

+#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
+				else if(sk->sk_family == PF_INET6     &&
+					ipv6_rcv_saddr_equal(sk, sk2)     )
+					goto fail;
+			}
+#endif

This is not good because you cannot link ipv6_rcv_saddr_equal()
if you are compiling IPv6 as module.

How about retaining udp_v{4,6}_get_port() and call
common udp_get_port() from both functions?

--yoshfuji