Re: skge crashes
From: Stephen Hemminger <hidden>
Date: 2006-08-17 03:39:26
possible PCI posting bug?
--- linux-2.6.orig/drivers/net/skge.c
+++ linux-2.6/drivers/net/skge.c@@ -2745,7 +2745,7 @@ static int skge_poll(struct net_device * spin_lock_irq(&hw->hw_lock); hw->intr_mask |= rxirqmask[skge->port]; skge_write32(hw, B0_IMSK, hw->intr_mask); - mmiowb(); + skge_read32(hw, B0_IMSK); spin_unlock_irq(&hw->hw_lock); return 0;
@@ -2879,6 +2879,7 @@ static void skge_extirq(void *arg) spin_lock_irq(&hw->hw_lock); hw->intr_mask |= IS_EXT_REG; skge_write32(hw, B0_IMSK, hw->intr_mask); + skge_read32(hw, B0_IMSK); spin_unlock_irq(&hw->hw_lock); }
@@ -2953,6 +2954,7 @@ static irqreturn_t skge_intr(int irq, vo skge_error_irq(hw); skge_write32(hw, B0_IMSK, hw->intr_mask); + skge_read32(hw, B0_IMSK); spin_unlock(&hw->hw_lock); return IRQ_HANDLED;