Re: [PATCH 4/5] d80211: Switch d80211 to IEEE80211_ style names
From: Michael Wu <hidden>
Date: 2006-08-04 22:10:55
Attachments
- (unnamed) [application/pgp-signature] 189 bytes
From: Michael Wu <hidden>
Date: 2006-08-04 22:10:55
On Friday 04 August 2006 12:20, Jouni Malinen wrote:
On Tue, Aug 01, 2006 at 09:16:59PM +0200, Jiri Benc wrote:
This kind of change is more than just search-and-replace since frame
type and subtype macros were using different style (not shifted left in
WLAN_FC_{TYPE,STYPE}_* and shifted left in IEEE80211_{FTYPE,STYPE}_*.
Some of these seemed to be caught in the patch, but not all. At least
the following changes look incorrect. I'm not sure whether this is a
complete list of issues, though, so going through all IEEE80211_STYPE_*
and IEEE80211_FTYPE_* cases again could be a worthwhile exercise.Thanks for the heads up. I tried to make sure everything using IEEE80211_[FS]TYPE_* was correct, but I'm not very familiar with the QoS stuff, so those got through. I'll patch up the QoS problems tonight and look through any other problem areas. -Michael Wu