[PATCH] ipv4: don't call upper-layer disconnect function if not connected

STALE7310d

3 messages, 2 authors, 2006-08-02 · open the first message on its own page

[PATCH] ipv4: don't call upper-layer disconnect function if not connected

From: Brian Haley <hidden>
Date: 2006-08-01 19:48:56

Calling connect() with AF_UNSPEC will disconnect a socket, but we don't 
need to do any work if the socket isn't currently connected.

Signed-off-by: Brian Haley <redacted>

Re: [PATCH] ipv4: don't call upper-layer disconnect function if not connected

From: David Miller <davem@davemloft.net>
Date: 2006-08-01 22:07:57

From: Brian Haley <redacted>
Date: Tue, 01 Aug 2006 15:48:54 -0400
Calling connect() with AF_UNSPEC will disconnect a socket, but we don't 
need to do any work if the socket isn't currently connected.

Signed-off-by: Brian Haley <redacted>
The socket could have been bind()'d to, in which case it will
not move to connected state and we still need to invoke
the disconnect methods such as udp_disconnect() to clear out
that binding.

You seem to be groveling in random areas of the ipv4 and ipv6 stack,
what are you working on?

Re: [PATCH] ipv4: don't call upper-layer disconnect function if not connected

From: Brian Haley <hidden>
Date: 2006-08-02 16:04:25

The socket could have been bind()'d to, in which case it will
not move to connected state and we still need to invoke
the disconnect methods such as udp_disconnect() to clear out
that binding.
Ok.
You seem to be groveling in random areas of the ipv4 and ipv6 stack,
what are you working on?
Was looking into a customer-reported memory leak that seemed to be in 
this code path.  It wasn't, but this tweak seemed sane at the time.

-Brian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help