[2.6 patch] let BT_HIDP depend on INPUT

On Mon, Jul 10, 2006 at 09:07:20PM +0200, Marcel Holtmann wrote:

Hi Adrian,

quoted

This patch let's BT_HIDP depend on instead of select INPUT.

This fixes the following warning during an s390 build:

<--  snip  -->

...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'INPUT'
...

<--  snip  -->

A dependency on INPUT also implies !S390 (and therefore makes the 
explicit dependency obsolete) since INPUT is not available on s390.

The practical difference should be nearly zero, since INPUT is always 
set to y unless EMBEDDED=y (or S390=y).

I actually have no idea why we ended up with using select, but depends
is also fine by me. Except I like to see it "BT && BT_L2CAP && INPUT" ;)

Updated patch below.

Regards

Marcel

cu
Adrian


<--  snip  -->



This patch lets BT_HIDP depend on instead of select INPUT.

This fixes the following warning during an s390 build:

<--  snip  -->

...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 
'BT_HIDP' r
efer to undefined symbol 'INPUT'
...

<--  snip  -->

A dependency on INPUT also implies !S390 (and therefore makes the 
explicit dependency obsolete) since INPUT is not available on s390.

The practical difference should be nearly zero, since INPUT is always 
set to y unless EMBEDDED=y (or S390=y).

Signed-off-by: Adrian Bunk <redacted>

--- linux-2.6.18-rc1-mm1-full/net/bluetooth/hidp/Kconfig.old	2006-07-10 16:51:59.000000000 +0200
+++ linux-2.6.18-rc1-mm1-full/net/bluetooth/hidp/Kconfig	2006-07-10 21:21:46.000000000 +0200

@@ -1,7 +1,6 @@
 config BT_HIDP
 	tristate "HIDP protocol support"
-	depends on BT && BT_L2CAP && (BROKEN || !S390)
-	select INPUT
+	depends on BT && BT_L2CAP && INPUT
 	help
 	  HIDP (Human Interface Device Protocol) is a transport layer
 	  for HID reports.  HIDP is required for the Bluetooth Human