Thread (53 messages) 53 messages, 9 authors, 2006-07-31

Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

From: Thomas Graf <tgraf@suug.ch>
Date: 2006-07-31 20:01:06

* Patrick McHardy [off-list ref] 2006-07-31 20:01
Thomas Graf wrote:
quoted
* Ville Nuorvala [off-list ref] 2006-07-31 17:46
quoted
Shouldn't all these (struct fib_rule_hdr included) actually be defined
in include/linux/rtnetlink.h?

We used to stuff everything into rtnetlink.h for no good reason. Having
independant include/linux/<subsystem>.h to export the interface to
userspace and include/net/<subsystem>.h to export the kernel interface
instead of contributing to the ifdef hell seems a lot cleaner to me.

I agree, but then we should also split up rtnetlink.h. Having one
special case will just make it harder to find.
Already done in the patchset converting things to the new netlink
interface that I'll start submiting in the next days.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help