Thread (2 messages) 2 messages, 2 authors, 2006-07-30

Re: linux- 2.6.17.7 undefined reference to `alloc_ltalkdev'

From: David Miller <davem@davemloft.net>
Date: 2006-07-30 22:54:36
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

From: Toralf Förster <redacted>
Date: Sat, 29 Jul 2006 20:55:11 +0200
Subject: linux- 2.6.17.7 undefined reference to `alloc_ltalkdev'
Bug is that appletalk is built modular, which is where
alloc_ltalkdev is exported from, but we allow users of
this symbol, such as the cops driver, to be built non-modular.

Luckily the fix is simple, we need to change CONFIG_DEV_APPLETALK
to be a 'tristate' instead of a 'bool'.  The following patch
is what I'll use to fix this bug.

Thanks for the report.

diff-tree 66d3ad53b6867aa1bc499062bd19f85bfeee2f9e (from d0ccba71dfe903a737d011d93a076c10cf487b19)
Author: David S. Miller [off-list ref]
Date:   Sun Jul 30 15:54:11 2006 -0700

    [ATALK]: Make CONFIG_DEV_APPLETALK a tristate.
    
    Otherwise we allow building appletalk drivers in-kernel when
    CONFIG_ATALK is modular.  That doesn't work because these drivers use
    symbols such as "alloc_talkdev" which is exported from code built
    by CONFIG_ATALK.
    
    Noticed by Toralf Förster.
    
    Signed-off-by: David S. Miller [off-list ref]
diff --git a/drivers/net/appletalk/Kconfig b/drivers/net/appletalk/Kconfig
index b14e890..0a0e0cd 100644
--- a/drivers/net/appletalk/Kconfig
+++ b/drivers/net/appletalk/Kconfig
@@ -29,7 +29,7 @@ config ATALK
 	  even politically correct people are allowed to say Y here.
 
 config DEV_APPLETALK
-	bool "Appletalk interfaces support"
+	tristate "Appletalk interfaces support"
 	depends on ATALK
 	help
 	  AppleTalk is the protocol that Apple computers can use to communicate
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help