On 30/07/06, James Morris [off-list ref] wrote:

On Sun, 30 Jul 2006, Stephen Hemminger wrote:

quoted

On Sun, 30 Jul 2006 21:38:02 +0200
Jesper Juhl [off-list ref] wrote:

quoted

There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
We are not freeing 'tbuf' on error.
Patch below fixes that.


Signed-off-by: Jesper Juhl <redacted>

Agreed, thanks for catching it.  The whole kfifo interface is kind of
annoying have to do an extra copy.

Might be cleaner to make a single return path for cleanup:

Signed-off-by: James Morris <jmorris@namei.org>

Looks ok to me.

-- 
Jesper Juhl [off-list ref]
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html